Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass defaultResolver into custom resolvers #7714

Merged
merged 1 commit into from
Jan 29, 2019
Merged

feat: pass defaultResolver into custom resolvers #7714

merged 1 commit into from
Jan 29, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 26, 2019

Summary

Fixes arcanis/jest-pnp-resolver#1

Test plan

Test updated

@SimenB SimenB mentioned this pull request Jan 26, 2019
Merged
arcanis
arcanis approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@arcanis
Copy link
Contributor

arcanis commented Jan 26, 2019

Seems like the snapshots have to be updated to account for the line numbers changing

thymikee
thymikee reviewed Jan 26, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having defaultResolver inside defaultResolver looks weird, isn't it? Can't we export it directly from jest-resolve as a part of public api?

@SimenB
Copy link
Member Author

SimenB commented Jan 26, 2019

@thymikee see the linked issue where we discussed this 🙂

It also matches e.g. extractDependencies in that it passes in the default implementation rather than requiring the consumer to import it

thymikee
thymikee approved these changes Jan 26, 2019
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the part about having dependency on jest-resolve, makes sense now!

@SimenB SimenB merged commit 3f4661f into jestjs:master Jan 29, 2019
@SimenB SimenB deleted the pass-default-resolver branch January 29, 2019 14:24
@danieldunderfelt
Copy link

When will this be available on NPM? I really need to use v24 because being without #7404 is a huge blocker.

@rubennorte
Copy link
Contributor

@danieldunderfelt this was part of v24.1.0 we released a couple of weeks ago.

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@SimenB @captain-yossarian
feat: pass defaultResolver into custom resolvers (jestjs#7714)
da2ec16
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

@thymikee thymikee thymikee approved these changes

@arcanis arcanis arcanis approved these changes

@rubennorte rubennorte Awaiting requested review from rubennorte

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't reach into build folder of jest-resolve
7 participants
@SimenB @arcanis @danieldunderfelt @rubennorte @thymikee @jeysal @facebook-github-bot